-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: implement SRR and various maintenance/improvement tasks. #118
Conversation
Yes, that will do the trick.
or
? |
basic.yaml shows an example of how to specify the indices. Here's a snippet: samplers:
ARR: {}
Random: {}
Validation:
queries: [[0, 1, 2], [3, 4, 5], [6, 7, 8]] (updated to reflect sampler renaming) |
Perfect, thanks! |
* Rename RandomSampling to Random * hasattr(self, 'get_queries') → self.run_get_queries
Most tests are passing locally, all except 3. That's a non-issue; I'm testing that errors get logged, and can't restart docker in the middle of the tests. If I could, those tests would pass. |
What does this PR implement?
It allows the following:
n_search
queries (instead of asynchronously).queries: [[0, 1, 2], [3, 4, 5]]
ininit.yaml
under thesamplers
heading.http://localhost:8421/?puid=foobar
.samplers_per_user
/query?ident=
.samplers_per_user
ininit.yaml
.sampling
key in init.yml.torch.no_grad
inscore
.Backwards incompatible changes
RandomSampling
toRandom
to fit with naming scheme of other samplers.Runner
toSampler
.Reference issues/PRs
This closes #114 and #117.