-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements around realistic crowdsourcing simulations #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, some reorganization
faster install, new packages
In total, the time required for the CI run to complete has gone from 22–23min to 15–16min, largely thanks to these basic speed enhancements: |
only used for initialization, so not super important
remove shuffle, change default for dwell
Salmon is working on my own machine; I think the tests have a bug (sigh). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement?
Over in salmon-experiments, I plan to run a set of experiments that use realistic timing for simulations (thanks to the data I have collected). This PR revolves around those improvements. The changes include:
[0, 4, 5]
and[0, 5, 4]
are not unique because the last two objects get switched randomly).RR
orRandomSampling
(but set thestopped
variable in the DB right away)n_threads=1
).mu
inCKL
to be 0.05 (as per the original NEXT paper)salmon.triplets.offline.OfflineEmbedding
's defaultnoise_model
toCKL
.n_search
inAdaptiveRunner
.TODO:
n_cores
workers are launched.Reference issues/PRs