feat: Protect compiler directives during mutation #3116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_directives # Conflicts: # src/Stryker.Core/Stryker.Core.UnitTest/Mutants/CsharpMutantOrchestratorTests.cs
…es (and revert them on roll back
…ssionmutator and replace it with two extra mutators, add semancticinfo to unit tests
dupdob
force-pushed
the
improve_mutation_of_directives
branch
from
c6e5ac8 to
6826228
Compare
dupdob
force-pushed
the
improve_mutation_of_directives
branch
from
f34711e to
e9ba29d
Compare
dupdob
force-pushed
the
improve_mutation_of_directives
branch
from
e9ba29d to
bfec606
Compare
dupdob
force-pushed
the
improve_mutation_of_directives
branch
from
c3017ec to
80871b8
Compare
|
I am happy to see this PR reduces the total number of lines, and it increases the number of mutations. This is probably related to the redesign of the pattern mutator that I modified so it no longer does some internal scan and reenabled orchestration of patterns in general |
dupdob
force-pushed
the
improve_mutation_of_directives
branch
from
4102df8 to
f5bbfd9
Compare
dupdob
force-pushed
the
improve_mutation_of_directives
branch
from
f5bbfd9 to
df53cc3
Compare
…_directives # Conflicts: # integrationtest/Validation/ValidationProject/ValidateStrykerResults.cs
…into improve_mutation_of_directives
integrationtest/TargetProjects/NetCore/EmptyTestProject/Main.cs
Outdated
Show resolved
Hide resolved
rouke-broersma
changed the title
…_directives # Conflicts: # integrationtest/Validation/ValidationProject/ValidateStrykerResults.cs
dupdob
force-pushed
the
improve_mutation_of_directives
branch
from
01a58fe to
60a7a04
Compare
dupdob
force-pushed
the
improve_mutation_of_directives
branch
from
6fad9f2 to
ba24808
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure compiler directives (#if, #pragma....) are not mutated but kept around mutated syntax nodes.
This required small changes in every mutator, as they are not responsible for removing any directive.
I took this as an opportunity to improve the design.
Also, added generation of semantic model during mutation tests to ensure mutator related unit tests are relevant.
I may have fixed some minor issues on them.
Also added some top level statement in integration test as it was a quick win
FIxes #3081, #3102