Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#1472): add excluding specific mutations #1660

Closed
wants to merge 7 commits into from
Closed

feat(#1472): add excluding specific mutations #1660

wants to merge 7 commits into from

Conversation

bartekleon
Copy link
Member

fixes #1472

@bartekleon
Copy link
Member Author

for now only

stryker:on
stryker:off
stryker:on MutatorName...
stryker:off MutatorName...

are working

stryker:next-on
stryker:next-off

are not implemented yet, since there were several problems with it

@bartekleon
Copy link
Member Author

next-on and next-off are working now!
Next thing is to do the same for typescript mutator :)

@bartekleon
Copy link
Member Author

Help needed. I can't extract a comment from TS file :/ any help would be nice

@Djaler
Copy link
Contributor

Djaler commented Jul 28, 2019

@kmdrGroch check this microsoft/TypeScript#21049 (comment)

@bartekleon
Copy link
Member Author

@Djaler I saw it, but it didn't really help me :/

@bartekleon
Copy link
Member Author

bartekleon commented Aug 1, 2019

@Djaler so with help of that comment, I somehow managed to get these comments.
But now I need some help with tests. Some of them aren't passing. @nicojs, @simondel, @Djaler any idea? (I am not even sure they are good, but looking at logs, they are) :< next-on and next-off don't work for sure

@nicojs
Copy link
Member

nicojs commented Aug 27, 2019

I would be happy to accept a merge request that only implements the babel-side of things. We will need to make clear remarks in the readme's

@bartekleon bartekleon closed this Sep 13, 2019
@bartekleon
Copy link
Member Author

I'd like #1718 this PR to be accepted, so I can start this over again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore specific mutations
3 participants