1.16.2: build fails because missing zlib.h

[kloczek]

Looks like there is no anywhere in cmake files zlib detection despite fact that libheif examples are using zlib

[ 56%] Building CXX object examples/CMakeFiles/heif-convert.dir/encoder_png.cc.o
cd /home/tkloczko/rpmbuild/BUILD/libheif-1.16.2/x86_64-redhat-linux-gnu/examples && /usr/bin/g++ -DHAVE_JPEG_WRITE_ICC_PROFILE=1 -DHAVE_LIBJPEG=1 -DHAVE_LIBPNG=1 -DHAVE_LIBSHARPYUV=1 -DHAVE_UNISTD_H -DHAVE_VISIBILITY -DLIBHEIF_EXPORTS -DWITH_UNCOMPRESSED_CODEC=1 -I/home/tkloczko/rpmbuild/BUILD/libheif-1.16.2/x86_64-redhat-linux-gnu -I/home/tkloczko/rpmbuild/BUILD/libheif-1.16.2 -I/home/tkloczko/rpmbuild/BUILD/libheif-1.16.2/include/libheif -I/home/tkloczko/rpmbuild/BUILD/libheif-1.16.2/include -O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections -flto=auto -flto-partition=none -DNDEBUG -std=c++11 -fPIE -fvisibility=hidden -fvisibility-inlines-hidden   -Wall -Werror -Wsign-compare -Wconversion -Wno-sign-conversion -Wno-error=conversion -Wno-error=unused-parameter -Wno-error=deprecated-declarations -MD -MT examples/CMakeFiles/heif-convert.dir/encoder_png.cc.o -MF CMakeFiles/heif-convert.dir/encoder_png.cc.o.d -o CMakeFiles/heif-convert.dir/encoder_png.cc.o -c /home/tkloczko/rpmbuild/BUILD/libheif-1.16.2/examples/encoder_png.cc
/home/tkloczko/rpmbuild/BUILD/libheif-1.16.2/examples/encoder_png.cc:31:10: fatal error: zlib.h: No such file or directory
   31 | #include <zlib.h>
      |          ^~~~~~~~
compilation terminated.

[bradh]

@kloczek Can you test #973?

[farindk]

That include is actually not needed. I've removed it again.

[kmilos]

That include is actually not needed. I've removed it again.

I was wondering about that, should be internal to PNG anyway... So that PR is not needed as well.

[kloczek]

I was wondering about that, should be internal to PNG anyway... So that PR is not needed as well.

None of the libpng header files depends on zlib.

[kmilos]

None of the libpng header files depends on zlib.

Never mentioned PNG header files...

https://github.com/glennrp/libpng/blob/ee9d6d7bf2bc91212e9d8f6906b09909b2481688/CMakeLists.txt#L81

[kloczek]

That include is actually not needed. I've removed it again.

That i=s even better 👍 😄