Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider the default settings of the rules #71

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

sasezaki
Copy link
Member

@sasezaki sasezaki commented Dec 8, 2023

  • MessageStaticStringRule should be enabled.
  • ContextRequireExceptionKeyRule should not be enabled by default, it is not PSR-3 specification, it is just more better practice.

Please write these parameters to your project's phpstan.neon !

parameters:
    sfpPsrLog:
        enableMessageStaticStringRule: true
        enableContextRequireExceptionKeyRule: true
        reportContextExceptionLogLevel: 'info'
        contextKeyOriginalPattern: '#\A[A-Za-z0-9-_]+\z#'

 - MessageStaticStringRule should be enabled.
- ContextRequireExceptionKeyRule should not be enabled by default, it is not PSR-3 specification, it is just more better practice.
@sasezaki sasezaki self-assigned this Dec 8, 2023
@sasezaki sasezaki added this to the 0.19.0 milestone Dec 8, 2023
@sasezaki sasezaki marked this pull request as ready for review December 8, 2023 12:27
@sasezaki sasezaki merged commit 8276964 into struggle-for-php:0.19.x Dec 8, 2023
5 checks passed
@sasezaki sasezaki deleted the notify-settings-readme branch December 8, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant