Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/promise #67

Merged
merged 1 commit into from
Jan 27, 2016
Merged

Feature/promise #67

merged 1 commit into from
Jan 27, 2016

Conversation

ritch
Copy link
Member

@ritch ritch commented Jan 18, 2016

No description provided.

@ritch ritch added the #review label Jan 18, 2016
@ritch
Copy link
Member Author

ritch commented Jan 18, 2016

@hacksparrow This looks great! I usually run the apidocs.strongloop.com project locally with this latest version to test out all the documentation before merging. Can you do that?

@hacksparrow
Copy link
Member

@ritch yes, I will do that.

@crandmck
Copy link

It's working locally for me with sdocs -p but I haven't tested the whole apidocs site.

@hacksparrow
Copy link
Member

@ritch I don't have access to the repo.

@crandmck
Copy link

@crandmck
Copy link

Hi @hacksparrow What's the status of landing this?

@hacksparrow
Copy link
Member

@crandmck I confirmed manually @promise to be working as expected on the apidocs.strongloop.com repo, apart from the accompanying unit tests.

@ritch shall I go ahead and merge this?

@ritch
Copy link
Member Author

ritch commented Jan 27, 2016

yes thanks

crandmck pushed a commit that referenced this pull request Jan 27, 2016
@crandmck crandmck merged commit 2893448 into master Jan 27, 2016
@crandmck crandmck removed the #review label Jan 27, 2016
@crandmck
Copy link

@hacksparrow Hope you don't mind I landed it. This is great, tyvm! Now to update the docs.

@hacksparrow
Copy link
Member

@crandmck no problem 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants