Support Windows on node >= 0.11.14 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Go ahead and merge it if it works for your tests. |
Clustering dgram sockets isn't supported on Windows, and can't be disabled until node 0.11.14. When dgram is clustered, node crashes. After 0.11.14 we can request dgram sockets not be clustered by using the new exclusive option to bind.
sam-github
force-pushed
the
use-exclusive
branch
from
2ae862c
to
699cccc
Compare
|
Added a cluster test, works on windows with node 0.11.14. |
sam-github
added a commit
that referenced
this pull request
Dec 4, 2014
Support Windows on node >= 0.11.14
sam-github
added a commit
that referenced
this pull request
Dec 4, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clustering dgram sockets isn't supported on Windows, and can't be
disabled until node 0.11.14. When dgram is clustered, node crashes.
After 0.11.14 we can request dgram sockets not be clustered by using the
new exclusive option to bind.
cf. nodejs/node-v0.x-archive#8643
/to @rmg still in the process of building node on Windows to prove this works, will PR to you after I do
/cc @chandadharap