Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about injectOptionsFromRemoteContext #3080

Merged
merged 1 commit into from
Jan 10, 2017

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Jan 9, 2017

The option injectOptionsFromRemoteContext was added to LoopBack 2.x only and is not available in LoopBack 3.x (and newer).

When a model with this option is encountered, we are printing a warning message now, to let the user know about this change between 2.x and 3.x.

Connect to #1495, see also #3048 which implemented the flag in 2.x

@superkhau PTAL
@crandmck could you please review the message?

The option injectOptionsFromRemoteContext was added to LoopBack 2.x only
and is not available in LoopBack 3.x (and newer).

When a model with this option is encountered, we are printing a warning
message now, to let the user know about this change between 2.x and 3.x.
@bajtos bajtos requested review from superkhau and crandmck January 9, 2017 13:47
@bajtos bajtos added the #review label Jan 9, 2017
@bajtos
Copy link
Member Author

bajtos commented Jan 9, 2017

The current message:

TestModel is using model setting injectOptionsFromRemoteContext which is no longer available.
Please rework your app to use the offical solution for injecting "options" argument from request context,
see http://loopback.io/doc/en/lb3/Using-current-context.html

@cgole cgole removed the #review label Jan 10, 2017
@bajtos bajtos merged commit b86eac5 into master Jan 10, 2017
@bajtos bajtos deleted the feature/warn-on-injectOptionsFromRemoteContext branch January 10, 2017 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants