Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore computed "accepts" arguments #16

Merged
merged 1 commit into from
Dec 22, 2016
Merged

Conversation

bajtos
Copy link
Contributor

@bajtos bajtos commented Dec 22, 2016

A downstream build of strongloop/loopback#3048 discovered a bug in our iOS SDK generator where server-computed "accepts" arguments were incorrectly included in the generated client methods.

This patch is fixing the generator to skip these arguments.

The code is coming from https://github.com/strongloop/loopback-swagger/blob/7e33fcf0cd2f6f7a6ee38d169ea89013ff18c239/lib/specgen/route-helper.js#L70-L84

@strongloop/sq-lb-apex and/or @gunjpan PTAL

See also strongloop/loopback#1495

@bajtos bajtos requested a review from gunjpan December 22, 2016 14:40
@bajtos bajtos added the #review label Dec 22, 2016
Copy link

@gunjpan gunjpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bajtos bajtos self-assigned this Dec 22, 2016
@bajtos bajtos merged commit b110a2f into master Dec 22, 2016
@bajtos bajtos deleted the fix/computed-arguments branch December 22, 2016 15:26
@bajtos bajtos removed the #review label Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants