Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create webhook endpoint #536

Merged
merged 2 commits into from
Feb 10, 2022
Merged

create webhook endpoint #536

merged 2 commits into from
Feb 10, 2022

Conversation

etsai-stripe
Copy link
Contributor

@etsai-stripe etsai-stripe commented Feb 9, 2022

Github Issue

#114

Screen Shot 2022-02-08 at 4 32 39 PM

Screen Shot 2022-02-08 at 4 33 02 PM

Screen Shot 2022-02-08 at 4 33 27 PM

Screen Shot 2022-02-09 at 3 14 13 PM

Screen Shot 2022-02-08 at 4 33 46 PM

Screen Shot 2022-02-08 at 4 34 17 PM

Screen Shot 2022-02-08 at 4 40 03 PM

Screen Shot 2022-02-08 at 4 35 06 PM

@etsai-stripe etsai-stripe requested review from gracegoo-stripe and vcheung-stripe and removed request for gracegoo-stripe February 9, 2022 00:37
Copy link
Collaborator

@vcheung-stripe vcheung-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor points, overall looks great!

src/commands.ts Outdated Show resolved Hide resolved
src/commands.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@vcheung-stripe vcheung-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@etsai-stripe etsai-stripe merged commit 41d209a into master Feb 10, 2022
@etsai-stripe etsai-stripe deleted the etsai/dx7014 branch February 10, 2022 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants