Allow non-integral X-Ray sampling rates #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👀 Heads Up
|
|
re-r? @stripe/observability |
cory-stripe
reviewed
Sep 16, 2020
| @@ -80,7 +80,7 @@ type XRaySpanSink struct { | |||
| var _ sinks.SpanSink = &XRaySpanSink{} | |||
|
|
|||
| // NewXRaySpanSink creates a new instance of a XRaySpanSink. | |||
| func NewXRaySpanSink(daemonAddr string, sampleRatePercentage int, commonTags map[string]string, annotationTags []string, log *logrus.Logger) (*XRaySpanSink, error) { | |||
| func NewXRaySpanSink(daemonAddr string, sampleRatePercentage float64, commonTags map[string]string, annotationTags []string, log *logrus.Logger) (*XRaySpanSink, error) { | |||
There was a problem hiding this comment.
Does this irritate the math.MaxUint32 below? (otherwise, it looks pretty simple)
There was a problem hiding this comment.
It actually doesn't! (it compiles, and I even test-logged the sample value).
If you're curious why it works: despite the semantic significance, math.MaxUint32 is actually defined as an untyped constant (MaxUint8 = 1<<8 - 1), so to the compiler, it's the same as multiplying a float64 by a hard-coded, untyped numeric literal.
There was a problem hiding this comment.
That was my suspicion, excellent!
philipnrmn
approved these changes
Sep 16, 2020
aditya-stripe
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow non-integer values to be set for X-Ray sampling rates. Notably, this allows users to set rates below 1% (without disabling X-Ray entirely).
Motivation
Test plan
Rollout/monitoring/revert plan
r? @stripe/observability