Update collect input to use FormType variable #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-lin-bbpos
requested review from
billfinn-stripe,
bric-stripe,
nazli-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
tim-lin-bbpos
commented
Oct 17, 2024
Comment on lines
+457
to
+490
| export interface SelectionResult extends ICollectInputsResult { | ||
| // selected button. Null if the form was skipped. | ||
| selection?: string | null; | ||
| } | ||
|
|
||
| // Contains data collected from a signature form | ||
| export interface SignatureResult extends ICollectInputsResult { | ||
| // signature in svg format. Null if the form was skipped. | ||
| signatureSvg?: string | null; | ||
| } | ||
|
|
||
| // Contains data collected from a phone form | ||
| export interface PhoneResult extends ICollectInputsResult { | ||
| // the submitted phone number in E.164 format. Null if the form was skipped. | ||
| phone?: string | null; | ||
| } | ||
|
|
||
| // Contains data collected from an email form | ||
| export interface EmailResult extends ICollectInputsResult { | ||
| // the submitted email. Null if the form was skipped. | ||
| email?: string | null; | ||
| } | ||
|
|
||
| // Contains data collected from a text form | ||
| export interface TextResult extends ICollectInputsResult { | ||
| // the submitted text. Null if the form was skipped. | ||
| text?: string | null; | ||
| } | ||
|
|
||
| // Contains data collected from an email form | ||
| export interface NumericResult extends ICollectInputsResult { | ||
| // the submitted number as a string. Null if the form was skipped. | ||
| numericString?: string | null; | ||
| } |
There was a problem hiding this comment.
@nazli-stripe A bit not clear about how user can use these types? Do they need to cast from the ICollectInputsResult directly?
There was a problem hiding this comment.
@nazli-stripe how about this? is it what we want?
| "" | ||
| } | ||
| } | ||
|
|
||
| class func mapFromCollectInputsResults(_ results: [CollectInputsResult]) -> NSDictionary { | ||
| var collectInputResults: [NSDictionary] = [] | ||
| for result in results { | ||
| if result is EmailResult { |
There was a problem hiding this comment.
we already have this check if result is EmailResult and don't need to call mapFormType as we are in the ifblock. We can directly set the formType to email. Same for other result types
There was a problem hiding this comment.
Instead of keeping the big if else growthing, given current each block is 80% the same, I'm wondering the possibility to extract that unique part in future pr and reduce duplication.
| @@ -779,6 +801,18 @@ internal fun mapFromReaderSettings(settings: ReaderSettings): ReadableMap { | |||
| } | |||
| } | |||
|
|
|||
| @OptIn(CollectInputs::class) | |||
| private fun CollectInputsResult.getFormType(): String { | |||
There was a problem hiding this comment.
same feedback as iOS
nazli-stripe
approved these changes
Oct 17, 2024
tim-lin-bbpos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update collect input to use FormType variable instead of each tag like: text, phone, etc.
Motivation
https://jira.corp.stripe.com/browse/TERMINAL-40991
Testing
Documentation
Select one: