Update withStripeTerminal variable reference link #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-lin-bbpos
requested review from
billfinn-stripe,
bric-stripe,
nazli-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
nazli-stripe
reviewed
Sep 4, 2024
README.md
Outdated
| @@ -154,7 +154,7 @@ export default function PaymentScreen() { | |||
| In case your app uses `React Class Components` you can use dedicated `withStripeTerminal` Higher-Order-Component. | |||
| Please note that unlike the hooks approach, you need to use event emitter to listen on specific events that comes from SDK. | |||
|
|
|||
| [Here](https://github.com/stripe/stripe-terminal-react-native/blob/main/src/hooks/useStripeTerminal.tsx#L51) you can find the list of available events to be used within the event emitter. | |||
| [Here](https://github.com/stripe/stripe-terminal-react-native/blob/main/src/hooks/useStripeTerminal.tsx#L85-L109) you can find the list of available events to be used within the event emitter. | |||
There was a problem hiding this comment.
thoughts on using the current latest commit instead of main in the url?
this will always link to what we intend to show and if things shift later users could be able to locate the new location based on example code
nazli-stripe
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update withStripeTerminal variable reference link
Motivation
The line number in source code file is shifted since the code is rapidly evolved, update and also point to a range instead of single line for now.
The original reference should be: https://github.com/stripe/stripe-terminal-react-native/blame/a534b8f8efb42ec033c278c4058bcf8755d2abf2/src/hooks/useStripeTerminal.tsx#L51
Testing
Documentation
Select one: