Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix infinite loop location api
Motivation
Using
useEffect
with multiple dependency might cause infinite loop as here.And also js is using
Object.is
to compare diff instead of the real content, so sometime what we think is the same isn't.The solution is to break single
useEffect
into two for now to avoid nested update trigger loop.Reference: https://bugs.bbpos.com/browse/SDK-219
Testing
Documentation
Select one: