Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

append to UIBackgroundModes instead of overriding it. #781

Merged
merged 5 commits into from
Aug 12, 2024
Merged

append to UIBackgroundModes instead of overriding it. #781

merged 5 commits into from
Aug 12, 2024

Conversation

a-eid
Copy link
Contributor

@a-eid a-eid commented Aug 11, 2024 •
edited
Loading

Summary

append to UIBackgroundModes instead of overriding it.

Motivation

fixes #780

Testing

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@CLAassistant
Copy link

CLAassistant commented Aug 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

nazli-stripe
nazli-stripe requested changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@nazli-stripe nazli-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

the bitrise build is failing lint tests. can you run yarn lint and fix the detected errors? after that we can merge the change!

@a-eid
Copy link
Contributor Author

a-eid commented Aug 12, 2024

@nazli-stripe yarn lint is passing for me locally now.

@nazli-stripe nazli-stripe merged commit 7581031 into stripe:main Aug 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazli-stripe nazli-stripe nazli-stripe approved these changes

@billfinn-stripe billfinn-stripe Awaiting requested review from billfinn-stripe billfinn-stripe is a code owner

@bric-stripe bric-stripe Awaiting requested review from bric-stripe bric-stripe is a code owner

@ugochukwu-stripe ugochukwu-stripe Awaiting requested review from ugochukwu-stripe ugochukwu-stripe is a code owner

@ebarrenechea-stripe ebarrenechea-stripe Awaiting requested review from ebarrenechea-stripe ebarrenechea-stripe is a code owner

@mshafrir-stripe mshafrir-stripe Awaiting requested review from mshafrir-stripe mshafrir-stripe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expo Plugin overrides UIBackgroundModes instead of appending to it.
3 participants
@a-eid @CLAassistant @nazli-stripe