Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong display of the "terminal.didRequestReaderDisplayMessage" #762

Merged
merged 5 commits into from
Jul 23, 2024
Merged

Fix wrong display of the "terminal.didRequestReaderDisplayMessage" #762

merged 5 commits into from
Jul 23, 2024

Conversation

EricLin-BBpos
Copy link
Collaborator

Summary

Fix wrong display of the "terminal.didRequestReaderDisplayMessage"

Motivation

Fix bug

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

nazli-stripe
nazli-stripe previously approved these changes Jul 23, 2024
View reviewed changes
@nazli-stripe nazli-stripe merged commit b29b611 into main Jul 23, 2024
3 checks passed
nazli-stripe pushed a commit that referenced this pull request Jul 23, 2024
@EricLin-BBpos @ianlin-bbpos @nazli-stripe
Fix wrong display of the "terminal.didRequestReaderDisplayMessage" (#762
0a61d84 
)

* Fix wrong display of the "terminal.didRequestReaderDisplayMessage"

* fix e2e test fail

* sort collect methods.

* revert log check string.

* sort collect methods.

---------

Co-authored-by: Ian Lin <ian.lin@bbpos.com>
nazli-stripe pushed a commit that referenced this pull request Jul 23, 2024
@EricLin-BBpos @ianlin-bbpos @nazli-stripe
Fix wrong display of the "terminal.didRequestReaderDisplayMessage" (#762
7b9dec2 
)

* Fix wrong display of the "terminal.didRequestReaderDisplayMessage"

* fix e2e test fail

* sort collect methods.

* revert log check string.

* sort collect methods.

---------

Co-authored-by: Ian Lin <ian.lin@bbpos.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazli-stripe nazli-stripe nazli-stripe approved these changes

@billfinn-stripe billfinn-stripe Awaiting requested review from billfinn-stripe billfinn-stripe is a code owner

@bric-stripe bric-stripe Awaiting requested review from bric-stripe bric-stripe is a code owner

@ugochukwu-stripe ugochukwu-stripe Awaiting requested review from ugochukwu-stripe ugochukwu-stripe is a code owner

@ebarrenechea-stripe ebarrenechea-stripe Awaiting requested review from ebarrenechea-stripe ebarrenechea-stripe is a code owner

@mshafrir-stripe mshafrir-stripe Awaiting requested review from mshafrir-stripe mshafrir-stripe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EricLin-BBpos @nazli-stripe @ianlin-bbpos