Wire up ability to write iOS unit tests #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not entirely sure what these were from but makes it a bit awkward to work in so proposing to rm assuming CI passes
took me a bit but made sense of how stripe-react-native is doing things and followed along. This sets up a mapperstests. The one test can be run from command line with xcodebuild test -workspace dev-app/ios/StripeTerminalReactNativeDevApp.xcworkspace -destination 'platform=iOS Simulator,name=iPhone 15' -scheme UnitTests but its not a worthwhile test but should unblock folks to add more.
bric-stripe
requested review from
billfinn-stripe,
nazli-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
nazli-stripe
approved these changes
Jul 22, 2024
nazli-stripe
approved these changes
Jul 22, 2024
nazli-stripe
pushed a commit
that referenced
this pull request
Sep 11, 2024
* rm missing references from the xcproj not entirely sure what these were from but makes it a bit awkward to work in so proposing to rm assuming CI passes * Stubbed runnable test took me a bit but made sense of how stripe-react-native is doing things and followed along. This sets up a mapperstests. The one test can be run from command line with xcodebuild test -workspace dev-app/ios/StripeTerminalReactNativeDevApp.xcworkspace -destination 'platform=iOS Simulator,name=iPhone 15' -scheme UnitTests but its not a worthwhile test but should unblock folks to add more. * Attempt to wire up to bitrise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Followed along with how stripe-react-native has things setup.
@testable import...so the classes are exposedI wrote a very simple, not very useful, test on the location status mapper as an example.
Motivation
tests!
Testing
CI
Documentation
Select one: