Add missing Reader callbacks #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricLin-BBpos
requested review from
billfinn-stripe,
bric-stripe,
nazli-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
| @@ -19,5 +19,8 @@ enum class ReactNativeConstants(val listenerName: String) { | |||
| CHANGE_OFFLINE_STATUS("didChangeOfflineStatus"), | |||
| FORWARD_PAYMENT_INTENT("didForwardPaymentIntent"), | |||
| REPORT_FORWARDING_ERROR("didReportForwardingError"), | |||
| DISCONNECT("didDisconnect") | |||
| DISCONNECT("didDisconnect"), | |||
| BATTERY_LEVEL_UPDATE("didBatteryLevelUpdate"), | |||
There was a problem hiding this comment.
didUpdateBatteryLevel ?
bric-stripe
reviewed
May 23, 2024
ios/Mappers.swift
Outdated
Comment on lines
838
to
842
| switch readerEvent { | ||
| case ReaderEvent.cardInserted: return "cardInserted" | ||
| case ReaderEvent.cardRemoved: return "cardRemoved" | ||
| default: return "unknown" | ||
| } |
There was a problem hiding this comment.
recommend using @unknown default so the compiler tells us when new entries are added
and should be able to remove the prefix
Suggested change
| switch readerEvent { | |
| case ReaderEvent.cardInserted: return "cardInserted" | |
| case ReaderEvent.cardRemoved: return "cardRemoved" | |
| default: return "unknown" | |
| } | |
| switch readerEvent { | |
| case .cardInserted: return "cardInserted" | |
| case .cardRemoved: return "cardRemoved" | |
| @unknown default: return "unknown" | |
| } |
There was a problem hiding this comment.
and should the values be the values from the enum?
export enum ReaderEvent {
CARD_INSERTED = 'CARD_INSERTED',
CARD_REMOVED = 'CARD_REMOVED',
}
? (not sure what's expected on the RN layer there - or does something else map them to that?)
ios/StripeTerminalReactNative.swift
Outdated
| @@ -21,6 +21,9 @@ enum ReactNativeConstants: String, CaseIterable { | |||
| case FORWARD_PAYMENT_INTENT = "didForwardPaymentIntent" | |||
| case REPORT_FORWARDING_ERROR = "didReportForwardingError" | |||
| case DISCONNECT = "didDisconnect" | |||
| case UPDATE_BATTERY_LEVEL = "didReportBatteryLevel" | |||
There was a problem hiding this comment.
didUpdateBatteryLevel
nazli-stripe
previously approved these changes
May 28, 2024
nazli-stripe
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add missing callbacks on ReaderListener and BluetoothReaderDelegate
Motivation
Ensure all the callbacks on native SDKs are supported:
Testing
Documentation
Select one: