Nullify collect cancelables after confirm #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazli-stripe
requested review from
billfinn-stripe,
bric-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
nazli-stripe
force-pushed
the
nazli/handle-ios-cancelable
branch
2 times, most recently
from
fd6c83e to
4c7f3b7
Compare
nazli-stripe
force-pushed
the
nazli/handle-ios-cancelable
branch
from
4c7f3b7 to
bf31f3d
Compare
bric-stripe
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For iOS reset all cancelables after confirm calls succeed.
Motivation
Currently we set cancelables to nil after collect confirms, which causes issues when trying to inspect PM and decline payments between collect and confirm.
Testing
Documentation
Select one: