Add metadata field to payment intent #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazli-stripe
requested review from
billfinn-stripe,
bric-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
bric-stripe
previously approved these changes
Apr 2, 2024
ios/Mappers.swift
Outdated
Comment on lines
147
to
150
| var metadataMap: NSDictionary? | ||
| if let refundMetadata = paymentIntent.metadata { | ||
| metadataMap = NSDictionary(dictionary: refundMetadata) | ||
| } |
There was a problem hiding this comment.
nit
Suggested change
| var metadataMap: NSDictionary? | |
| if let refundMetadata = paymentIntent.metadata { | |
| metadataMap = NSDictionary(dictionary: refundMetadata) | |
| } | |
| var metadataMap: NSDictionary? | |
| if let intentMetadata = paymentIntent.metadata { | |
| metadataMap = NSDictionary(dictionary: intentMetadata) | |
| } |
There was a problem hiding this comment.
oops fixed in 0af8410
bric-stripe
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds metadata field when returning PI
Motivation
Add missing fields
Testing
Documentation
Select one: