Add rebootReader method #629
Conversation
ianlin-bbpos
requested review from
billfinn-stripe,
bric-stripe,
nazli-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
There was a problem hiding this comment.
changes lgtm with a small change request to not clear the connected reader after reboot. I tested this branch and confirmed if auto reconnect is enabled it would lose that state. I think you can just remove that clearing and rely on the existing disconnect callback handling to reset the connected reader state.
src/hooks/useStripeTerminal.tsx
Outdated
| if (!response.error) { | ||
| setConnectedReader(null); | ||
| setDiscoveredReaders([]); | ||
| } |
There was a problem hiding this comment.
I don't think we want to clear the connected reader. If the user enabled auto-reconnect the SDK will start attempting to reconnect when the rebooted reader disconnects. That reconnect may fail but that's OK. We should rely on the existing disconnect callbacks to clear the connected reader
There was a problem hiding this comment.
yes, I removed the codes and gave a test, it works well then. thanks!
Summary
Add rebootReader method.
Motivation
Support rebootReader SDK method.
Testing
Documentation
Select one: