Support reader disconnect reason #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianlin-bbpos
requested review from
billfinn-stripe,
bric-stripe,
nazli-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
bric-stripe
reviewed
Feb 29, 2024
ios/Mappers.swift
Outdated
Comment on lines
606
to
611
| case DisconnectReason.disconnectRequested: return "disconnect requested" | ||
| case DisconnectReason.rebootRequested: return "reboot requested" | ||
| case DisconnectReason.securityReboot: return "security reboot" | ||
| case DisconnectReason.criticallyLowBattery: return "critically low battery" | ||
| case DisconnectReason.poweredOff: return "powered off" | ||
| case DisconnectReason.bluetoothDisabled: return "bluetooth disabled" |
There was a problem hiding this comment.
shouldn't these (and the android ones) be mapping to the same strings found in src/types/Reader.ts?
There was a problem hiding this comment.
oh, I defined it already in Reader.ts and each Mapper, but considering the grammar of Alert msg, I change the words in mapper but missed Reader.ts. Let me meke them consistent.
nazli-stripe
requested changes
Mar 1, 2024
src/types/Reader.ts
Outdated
Comment on lines
113
to
118
| | 'disconnect requested' | ||
| | 'reboot requested' | ||
| | 'security reboot' | ||
| | 'critically low battery' | ||
| | 'powered off' | ||
| | 'bluetooth disabled' |
There was a problem hiding this comment.
we usually use camelCase for these strings, can we keep these as disconnectRequested etc and change the mappers in the native layer to follow that format? @ianlin-bbpos
There was a problem hiding this comment.
ok, I'll do it.
nazli-stripe
previously approved these changes
Mar 4, 2024
nazli-stripe
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support reader disconnect reason
Motivation
Support new reader disconnected callback and disconnect reason enum.
Testing
Documentation
Select one: