Fix offline status #579
Merged
Fix offline status #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazli-stripe
force-pushed
the
nazli/off-fix
branch
from
ecfecb5 to
00f3e3c
Compare
nazli-stripe
commented
Dec 4, 2023
nazli-stripe
requested review from
billfinn-stripe,
bric-stripe and
chr-stripe
as code owners
billfinn-stripe
previously approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Fixes offlineStatus reporting by the SDK. Both
onDidChangeOfflineStatusandgetOfflineStatusshould report the fullofflineStatusobject for reader and sdk.Updates Android and iOS to return errors only when they exists, and updates dev-app to handle undefined error
Testing
Documentation
Select one: