bump native SDKs to 3.1 #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add user cancellation for internet readers.
ianlin-bbpos
requested review from
billfinn-stripe,
bric-stripe,
nazli-stripe,
rv-stripe and
chr-stripe
as code owners
chr-stripe
previously approved these changes
Oct 19, 2023
| @@ -537,12 +541,13 @@ class StripeTerminalReactNativeModule(reactContext: ReactApplicationContext) : | |||
| } | |||
|
|
|||
| val customerConsentCollected = getBoolean(params, "customerConsentCollected") | |||
| val enableCustomerCancellation = getBoolean(params, "enableCustomerCancellation") | |||
There was a problem hiding this comment.
Does getBoolean() default to false if it's not provided?
There was a problem hiding this comment.
| @@ -4,6 +4,7 @@ import android.annotation.SuppressLint | |||
| import android.app.Application | |||
| import android.content.ComponentCallbacks2 | |||
| import android.content.res.Configuration | |||
| import android.util.Log | |||
There was a problem hiding this comment.
this seems unused ✂️
Comment on lines
189
to
193
| export type CollectSetupIntentPaymentMethodParams = { | ||
| customerConsentCollected?: boolean; | ||
| enableCustomerCancellation?: boolean; | ||
| setupIntent: SetupIntent.Type; | ||
| }; |
There was a problem hiding this comment.
Does order matter?
Also in the other SDKs, we create a new "config" class that contained the enableCustomerCancellation param.
There was a problem hiding this comment.
Hi, Michael, the order doesnt matter, we just need to match them well. right? @nazli-stripe
ianlin-bbpos
dismissed stale reviews from bric-stripe and chr-stripe
via
05cce13
nazli-stripe
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
bump native SDKs to 3.1.0.
Motivation
add user cancellation for internet readers.
Testing
Documentation
Select one: