bump native sdk to v3 #544

ianlin-bbpos · 2023-09-18T04:30:47Z

Summary

bump native sdk to v3

Motivation

Update the native SDKs to 3.0.

Testing

I tested this manually
I added automated tests

Documentation

Select one:

I have added relevant documentation for my changes.
This PR does not result in any developer-facing changes.

- add implementation 'com.facebook.soloader:soloader:0.10. 4+' to fix issue of 'couldn't find DSO to load'. - remove test menu and test items in e2e related to 'readReusableCard'.

dev-app/src/screens/HomeScreen.tsx

…ve-sdk-to-v3-for-android

chr-stripe · 2023-09-19T15:56:11Z

android/src/main/java/com/stripeterminalreactnative/StripeTerminalReactNativeModule.kt

@@ -516,6 +518,9 @@ class StripeTerminalReactNativeModule(reactContext: ReactApplicationContext) :
            collectSetupIntentCancelable = terminal.collectSetupIntentPaymentMethod(
                setupIntent,
                customerConsentCollected,
+                SetupIntentConfiguration.Builder()
+                    .setEnableCustomerCancellation(false)


For future note, would be nice to allow developers to configure this value for payment intents/setup intents/refunds. Definitely doesn't have to be done in this PR, though.

ok, got it~

chr-stripe · 2023-09-19T16:01:05Z

android/src/main/java/com/stripeterminalreactnative/StripeTerminalReactNativeModule.kt

-        terminal.createPaymentIntent(intentParams.build(), RNPaymentIntentCallback(promise) {
-            paymentIntents[it.id] = it
+        terminal.createPaymentIntent(intentParams.build(), RNPaymentIntentCallback(promise) { pi ->
+            pi.id?.let { paymentIntents[it] = pi }


I think as long as we're not yet supporting offline mode in React Native, it's okay to simply require that the id exists and crash if it doesn't:

Suggested change

pi.id?.let { paymentIntents[it] = pi }

paymentIntents[it.id!!] = it

alternatively you could fall back to the offline mode id as well, if it exists:

Suggested change

pi.id?.let { paymentIntents[it] = pi }

(pi.id ?: pi.offlineDetails?.id)?.let { paymentIntents[it] = pi }

(this would apply to all the other places we're doing pi.id?.let { ... })

ok, let me optimize it, thanks a lot.

chr-stripe · 2023-09-20T00:06:05Z

dev-app/android/app/build.gradle

@@ -258,6 +258,7 @@ dependencies {
    implementation fileTree(dir: "libs", include: ["*.jar"])
    //noinspection GradleDynamicVersion
    implementation "com.facebook.react:react-native:+"  // From node_modules
+    implementation 'com.facebook.soloader:soloader:0.10.4+'


What is this new dependency for?

It's added for solving this issue which also happened in our case of running "e2e:test:build:release" test, where the app would crash on the beginning with error "java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libjscexecutor.so".

Can we change this to use a strict version instead of a dynamic one? I think using 0.10.4+ means it will just pick up the latest 0.10.* version, which currently is 0.10.5:

Suggested change

implementation 'com.facebook.soloader:soloader:0.10.4+'

implementation 'com.facebook.soloader:soloader:0.10.5'

…stripe/stripe-terminal-react-native into bbpos/bump-native-sdk-to-v3-for-android

nazli-stripe · 2023-09-21T12:20:11Z

ios/StripeTerminalReactNative.swift

        Terminal.shared.createPaymentIntent(paymentIntentParams) { pi, error in
            if let error = error as NSError? {
                resolve(Errors.createError(nsError: error))
            } else if let pi = pi {
                let paymentIntent = Mappers.mapFromPaymentIntent(pi)
                self.paymentIntents[pi.stripeId] = pi
-                resolve(["paymentIntent": paymentIntent])
+                                resolve(["paymentIntent": paymentIntent])


is the whitespace here intentional?

will fix it

nazli-stripe · 2023-09-21T12:26:55Z

thanks for the sdk changes! we also need to update the files in the src directory to rename process calls to confirm, remove readReusableCard, update types etc

bric-stripe

👋 filed some feedback on the iOS side. Mostly just updating from try? to a do/catch so we can provide the error in the resolves

dev-app/ios/StripeTerminalReactNativeDevApp/Info.plist

ios/Errors.swift

ios/Mappers.swift

ios/StripeTerminalReactNative.swift

nazli-stripe · 2023-09-28T21:33:39Z

ios/StripeTerminalReactNative.swift

+        let connectionConfig: LocalMobileConnectionConfiguration
+        do {
+            connectionConfig = try LocalMobileConnectionConfigurationBuilder(locationId: locationId ?? selectedReader.locationId ?? "")
+                .setMerchantDisplayName(nil) // use the location name


we should support users passing a merchant display name. there is also a tosAcceptancePermitted field we should add
cc @bric-stripe

…while using ConnectLocalMobileReader.

chr-stripe

One or two comments for the Android changes, but overall looks good 👍

chr-stripe · 2023-09-29T18:13:34Z

android/src/main/java/com/stripeterminalreactnative/StripeTerminalReactNativeModule.kt

        context.registerComponentCallbacks(
            object : ComponentCallbacks2 {
-                override fun onTrimMemory(level: Int) {
-                    onTrimMemory(context.applicationContext as Application, level)
-                }
-
+                override fun onTrimMemory(level: Int) {}
                override fun onLowMemory() {}
                override fun onConfigurationChanged(p0: Configuration) {}
            })


nit: you can delete this entire init { ... } block now since we're not actually doing anything with these ComponentCallbacks2.

chr-stripe · 2023-09-29T18:17:48Z

dev-app/android/app/build.gradle

@@ -258,6 +258,7 @@ dependencies {
    implementation fileTree(dir: "libs", include: ["*.jar"])
    //noinspection GradleDynamicVersion
    implementation "com.facebook.react:react-native:+"  // From node_modules
+    implementation 'com.facebook.soloader:soloader:0.10.4+'


Can we change this to use a strict version instead of a dynamic one? I think using 0.10.4+ means it will just pick up the latest 0.10.* version, which currently is 0.10.5:

Suggested change

implementation 'com.facebook.soloader:soloader:0.10.4+'

implementation 'com.facebook.soloader:soloader:0.10.5'

bric-stripe

iOS changes look good, thanks for all the updates!

Only open item I'm aware of is sorting out the nullable stripe id concern. I'm OK if we want to merge this as-is and fix that up in a separate PR or do it in this PR.

bric-stripe · 2023-09-29T20:30:11Z

ios/Errors.swift

@@ -169,7 +174,85 @@ extension ErrorCode.Code {
            return "ReaderConnectionConfigurationInvalid"
        case .bluetoothReconnectStarted:
            return "BluetoothReconnectStarted"
-        default:
+        case .accountIdMismatchWhileForwarding:


wow, this was a lot more than I expected. Thanks for adding all these! 🙏

bric-stripe · 2023-09-29T20:31:58Z

ios/StripeTerminalReactNative.swift

+        let config: DiscoveryConfiguration
+        do {
+            config = try Mappers.mapToDiscoveryConfiguration(discoveryMethod, simulated: simulated ?? false)
+        } catch {
+            resolve(Errors.createError(nsError: error as NSError))


👍 thanks for updating all these

feedback addressed

bump native sdk to v3 for android

ef792cd

ianlin-bbpos requested review from billfinn-stripe, bric-stripe, nazli-stripe, rv-stripe and chr-stripe as code owners September 18, 2023 04:30

fix e2e-android test failed issues

4b1848f

- add implementation 'com.facebook.soloader:soloader:0.10. 4+' to fix issue of 'couldn't find DSO to load'. - remove test menu and test items in e2e related to 'readReusableCard'.

nazli-stripe reviewed Sep 18, 2023

View reviewed changes

dev-app/src/screens/HomeScreen.tsx Show resolved Hide resolved

EricLin-BBpos added 2 commits September 19, 2023 14:09

bump native sdk to v3 for ios

0982ce4

Merge branch 'bump-native-sdk-to-v3-for-android' into bbpos/bump-nati…

cf301ef

…ve-sdk-to-v3-for-android

EricLin-BBpos changed the title ~~bump native sdk to v3 for android~~ bump native sdk to v3 Sep 19, 2023

chr-stripe reviewed Sep 20, 2023

View reviewed changes

EricLin-BBpos and others added 4 commits September 20, 2023 11:02

fix collect paymentIntent fail

0c0f29b

optimization error message.

9fd14df

optimize codes.

1dcfd74

Merge branch 'bbpos/bump-native-sdk-to-v3-for-android' of github.com:…

0a9b367

…stripe/stripe-terminal-react-native into bbpos/bump-native-sdk-to-v3-for-android

EricLin-BBpos requested review from nazli-stripe and chr-stripe September 20, 2023 09:31

nazli-stripe reviewed Sep 21, 2023

View reviewed changes

bric-stripe previously requested changes Sep 21, 2023

View reviewed changes

ianlin-bbpos and others added 3 commits September 26, 2023 17:23

update related files in the src directory.

5f46cb0

delete unused variable.

672dee7

Replace guard let with do/catch and resolve errors

7026de5

ianlin-bbpos requested review from bric-stripe, nazli-stripe and EricLin-BBpos September 27, 2023 05:48

Add back accidentally deleted resources

79cf69d

nazli-stripe mentioned this pull request Sep 28, 2023

Update min version to ios 12.0 min target version? #545

Closed

nazli-stripe reviewed Sep 28, 2023

View reviewed changes

Support users passing merchantDisplayName and tosAcceptancePermitted …

942a464

…while using ConnectLocalMobileReader.

chr-stripe approved these changes Sep 29, 2023

View reviewed changes

bric-stripe reviewed Sep 29, 2023

View reviewed changes

nazli-stripe merged commit c6fa329 into main Sep 29, 2023

nazli-stripe deleted the bbpos/bump-native-sdk-to-v3-for-android branch September 7, 2024 17:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump native sdk to v3 #544

bump native sdk to v3 #544

ianlin-bbpos commented Sep 18, 2023 •

edited by EricLin-BBpos

Loading

chr-stripe Sep 19, 2023

ianlin-bbpos Sep 20, 2023

chr-stripe Sep 19, 2023

ianlin-bbpos Sep 20, 2023

chr-stripe Sep 20, 2023

ianlin-bbpos Sep 20, 2023

chr-stripe Sep 29, 2023

nazli-stripe Sep 21, 2023

EricLin-BBpos Sep 22, 2023

nazli-stripe commented Sep 21, 2023

bric-stripe left a comment

nazli-stripe Sep 28, 2023

chr-stripe left a comment

chr-stripe Sep 29, 2023

chr-stripe Sep 29, 2023

bric-stripe left a comment

bric-stripe Sep 29, 2023

bric-stripe Sep 29, 2023

	pi.id?.let { paymentIntents[it] = pi }
	paymentIntents[it.id!!] = it

	pi.id?.let { paymentIntents[it] = pi }
	(pi.id ?: pi.offlineDetails?.id)?.let { paymentIntents[it] = pi }

	implementation 'com.facebook.soloader:soloader:0.10.4+'
	implementation 'com.facebook.soloader:soloader:0.10.5'

bump native sdk to v3 #544

bump native sdk to v3 #544

Conversation

ianlin-bbpos commented Sep 18, 2023 • edited by EricLin-BBpos Loading

Summary

Motivation

Testing

Documentation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nazli-stripe commented Sep 21, 2023

bric-stripe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chr-stripe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bric-stripe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ianlin-bbpos commented Sep 18, 2023 •

edited by EricLin-BBpos

Loading