Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS build optimizations #166

Merged
merged 9 commits into from
Mar 16, 2022
Merged

iOS build optimizations #166

merged 9 commits into from
Mar 16, 2022

Conversation

dhenry-stripe
Copy link
Contributor

@dhenry-stripe dhenry-stripe commented Mar 16, 2022 •
edited
Loading

Addresses: #43

  • Pre-booting simulator
  • More granular Brew caches + using Brewfile checksum as cache key

jdivock-stripe
jdivock-stripe approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@jdivock-stripe jdivock-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dhenry-stripe dhenry-stripe merged commit 41904e1 into main Mar 16, 2022
arekkubaczkowski pushed a commit to arekkubaczkowski/stripe-terminal-react-native that referenced this pull request Jun 29, 2022
@dhenry-stripe @arekkubaczkowski
iOS build optimizations (stripe#166)
3bc1ccf 
* removed brew install android-commandlinetools

* preboot iOS simulator

* version int to string

* device name fix

* Added Brewfile

* Granular brew caches

* Brewfile checksum for cache key

* typo

* brew update
@nazli-stripe nazli-stripe deleted the dhenry/ios-build-optimizations branch September 6, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdivock-stripe jdivock-stripe jdivock-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhenry-stripe @jdivock-stripe