Replaced event name string matching with ReactNative exported constants #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdivock-stripe
approved these changes
Mar 16, 2022
dhenry-stripe
force-pushed
the
dhenry/rn-constants-listener-names
branch
from
d58b54f to
7b782f1
Compare
arekkubaczkowski
pushed a commit
to arekkubaczkowski/stripe-terminal-react-native
that referenced
this pull request
Jun 29, 2022
…ts (stripe#164) * Exporting event name constants from Android and iOS, consuming in JS * Updated exported event names * Unique log name keys * overriding hasConstants * react native constants used by iOS SDK * merge fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exporting constants from Android and iOS and consuming in JS to reduce opportunities for drift between the three systems