Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getListLocations -> getLocations #162

Merged
merged 2 commits into from
Mar 15, 2022
Merged

getListLocations -> getLocations #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4014f68
getListLocations -> getLocations
jdivock-stripe Mar 15, 2022
be1e088
rename params as well
jdivock-stripe Mar 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/src/main/java/com/stripeterminalreactnative/StripeTerminalReactNativeModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ class StripeTerminalReactNativeModule(reactContext: ReactApplicationContext) :

@ReactMethod
@Suppress("unused")
fun getListLocations(params: ReadableMap, promise: Promise) {
fun getLocations(params: ReadableMap, promise: Promise) {
val listParameters = ListLocationsParameters.Builder()
listParameters.endingBefore = getStringOr(params, "endingBefore")
listParameters.startingAfter = getStringOr(params, "startingAfter")
Expand All @@ -565,7 +565,7 @@ class StripeTerminalReactNativeModule(reactContext: ReactApplicationContext) :
override fun onSuccess(locations: List<Location>, hasMore: Boolean) {
val list = mapFromListLocations(locations)
val result = WritableNativeMap()
result.putArray("locationsList", list)
result.putArray("locations", list)
result.putBoolean("hasMore", hasMore)
promise.resolve(result)
}
Expand Down
2 changes: 1 addition & 1 deletion example/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,6 @@ SPEC CHECKSUMS:
StripeTerminal: 2c7d261881b0039693a6ba30c00e1e6133e6d393
Yoga: 32a18c0e845e185f4a2a66ec76e1fd1f958f22fa

PODFILE CHECKSUM: 617d5d5a75b2b359fc53061af7f2624d7349ec04
PODFILE CHECKSUM: 7dc744410dfefabb790965a6dbea3cfd4138e31c

COCOAPODS: 1.11.2
8 changes: 4 additions & 4 deletions example/src/screens/LocationListScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@ export default function LocationListScreen() {
const navigation = useNavigation();
const { params } = useRoute<RouteProp<any, any>>();

const { getListLocations, loading } = useStripeTerminal();
const { getLocations, loading } = useStripeTerminal();
const [list, setList] = useState<Location[]>([]);

useEffect(() => {
async function init() {
const { locationsList } = await getListLocations({ limit: 20 });
if (locationsList) {
setList(locationsList);
const { locations } = await getLocations({ limit: 20 });
if (locations) {
setList(locations);
}
}
init();
Expand Down
Loading