ReadReusableCard and SetupIntent optional customerId support (#119)

stripe · Mar 3, 2022 · 52ba89c · 52ba89c
1 parent dbd4bd0
commit 52ba89c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 16 deletions.
diff --git a/android/src/main/java/com/stripeterminalreactnative/StripeTerminalReactNativeModule.kt b/android/src/main/java/com/stripeterminalreactnative/StripeTerminalReactNativeModule.kt
@@ -451,11 +451,9 @@ class StripeTerminalReactNativeModule(reactContext: ReactApplicationContext) :
 
   @ReactMethod
   fun createSetupIntent(params: ReadableMap, promise: Promise) {
-    val customerId = getStringOr(params, "customerId") ?: ""
-
-    val intentParams = SetupIntentParameters.Builder()
-      .setCustomer(customerId)
-      .build()
+    val intentParams = getStringOr(params, "customer")?.let { customerId ->
+      SetupIntentParameters.Builder().setCustomer(customerId).build()
+    } ?: SetupIntentParameters.NULL
 
     Terminal.getInstance().createSetupIntent(intentParams, object : SetupIntentCallback {
       override fun onSuccess(setupIntent: SetupIntent) {
@@ -691,14 +689,9 @@ class StripeTerminalReactNativeModule(reactContext: ReactApplicationContext) :
 
   @ReactMethod
   fun readReusableCard(params: ReadableMap, promise: Promise) {
-    validateRequiredParameters(params, listOf("customer"))?.let {
-      promise.resolve(createError(CommonErrorType.Failed.toString(), "You must provide $it parameters."))
-      return
-    }
-
-    val customer = getStringOr(params, "customer")?: ""
-
-    var reusableCardParams = ReadReusableCardParameters.Builder().setCustomer(customer).build();
+    val reusableCardParams = getStringOr(params, "customer")?.let { customerId ->
+     ReadReusableCardParameters.Builder().setCustomer(customerId).build()
+    } ?: ReadReusableCardParameters.NULL
 
     readReusableCardCancelable = Terminal.getInstance().readReusableCard(reusableCardParams, object : PaymentMethodCallback {
       override fun onSuccess(paymentMethod: PaymentMethod) {

diff --git a/example/src/screens/ReadReusableCardScreen.tsx b/example/src/screens/ReadReusableCardScreen.tsx
@@ -59,7 +59,6 @@ export default function ReadReusableCardScreen() {
 
     if (customerError) {
       console.error(customerError);
-      return;
     }
 
     const { paymentMethod, error } = await readReusableCard({

diff --git a/example/src/screens/SetupIntentScreen.tsx b/example/src/screens/SetupIntentScreen.tsx
@@ -102,7 +102,6 @@ export default function SetupIntentScreen() {
 
       if (customerError) {
         console.error(customerError);
-        return;
       }
 
       const response = await createSetupIntent({

diff --git a/example/src/utils.ts b/example/src/utils.ts
@@ -13,7 +13,7 @@ export const fetchCustomerId = async () => {
     const { customers } = await response.json();
 
     if (customers.length === 0) {
-      return { error: 'There is no any customer created yet.' };
+      return { error: 'No customers available.' };
     }
     const { id } = customers[0] as { id: string };
-Original file line number
+Diff line change
@@ Expand Up / @@ -59,7 +59,6 @@ export default function ReadReusableCardScreen() { @@
         if (customerError) {
           console.error(customerError);
-          return;
         }
         const { paymentMethod, error } = await readReusableCard({
@@ Expand Down @@