Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.5.0 #134

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Release 2.5.0 #134

merged 1 commit into from
Jan 24, 2022

Conversation

bric-stripe
Copy link
Collaborator

  • Adds a new error code, SCPErrorBluetoothConnectionFailedBatteryLow, that is passed into the connectBluetoothReader completion handler when connection failed due to the reader's battery being critically low.
  • Fixes Issue #124: Crash when Bluetooth reader reports low battery but BluetoothReaderDelegate was released.
  • Fixes Issue #121: SCPReader isCharging and batteryLevel weren't being updated if the SCPBluetoothReaderDelegate didReportBatteryLevel: wasn't implemented.

Copy link
Collaborator

@jil-stripe jil-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bric-stripe bric-stripe merged commit 4a3dff5 into master Jan 24, 2022
@allendav
Copy link

Adds a new error code, SCPErrorBluetoothConnectionFailedBatteryLow, that is passed into the connectBluetoothReader completion handler when connection failed due to the reader's battery being critically low.

Thank you for adding this! I assume this doesn't require any particular version of firmware to be active on a reader, correct? (i.e. Stripe Terminal SDK 2.5.0 is able to identify this situation on its own)

@bric-stripe
Copy link
Collaborator Author

I assume this doesn't require any particular version of firmware to be active on a reader, correct?

@allendav that's correct, was an SDK side only fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on trying to collectPaymentMethod with low battery Battery Level not being refreshed
3 participants