Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: add customization options to CardForm on Android only #849

Merged

Conversation

charliecruzan-stripe
Copy link
Collaborator

@charliecruzan-stripe charliecruzan-stripe commented Mar 16, 2022

Summary

Allows the same customization options exposed to CardField

Motivation

Closes #771 and half of #563

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@charliecruzan-stripe charliecruzan-stripe force-pushed the charliecruzan-CardFormView-customization-android branch from 171efeb to 5c0d722 Compare April 11, 2022 16:59
@charliecruzan-stripe charliecruzan-stripe changed the title feat: add customization options to CardForm on Android only BREAKING: add customization options to CardForm on Android only Apr 11, 2022
@charliecruzan-stripe charliecruzan-stripe marked this pull request as ready for review April 11, 2022 21:10
@charliecruzan-stripe charliecruzan-stripe force-pushed the charliecruzan-CardFormView-customization-android branch from e1daa6d to a32c6d0 Compare April 22, 2022 13:51
@gauravag23
Copy link

You can check color scheme and set cardStyle={{backgroundColor: Appearance.getColorScheme() == 'dark' ? '#000000':'#ffffff'}}as per light or dark theme.

         <CardForm
                cardStyle={{backgroundColor: Appearance.getColorScheme() == 'dark' ? '#000000':'#ffffff'}}
             
            />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android - CardForm wouldn't accept style on light themed app
2 participants