fix: pass null instead of empty string for routing number #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acomley-stripe
approved these changes
Feb 16, 2022
charliecruzan-stripe
force-pushed
the
charliecruzan/fixbankaccountcrash
branch
from
69818e0
to
7b5b6c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Android apps would crash if routing number passed was an empty string, so now we default to null. Also added a check to help out folks in the US- routing numbers are required for US bank accounts.
Additionally, the
runCatchingblock wasn't catching errors thrown inside ofCoroutineScope, so moved that inside the block.Motivation
Fixes #807
Testing
Documentation
Select one: