-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade native stripe libraries #801
Merged
charliecruzan-stripe
merged 5 commits into
master
from
charliecruzan-upgrade-native-libs
Feb 9, 2022
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bf29f99
fix: upgrade underlying native stripe libraries
charliecruzan-stripe 0053771
chore: pod install
charliecruzan-stripe 1703f8e
chore: support android 12 in example
charliecruzan-stripe d803ec0
fix: some breaking upgrade changes, add back test,rm unused gradle props
charliecruzan-stripe db02c74
chore: changelog
charliecruzan-stripe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1 @@ | ||
StripeSdk_kotlinVersion=1.5.10 | ||
StripeSdk_compileSdkVersion=28 | ||
StripeSdk_buildToolsVersion=28.0.3 | ||
StripeSdk_targetSdkVersion=28 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,20 @@ | ||
require "json" | ||
require 'json' | ||
|
||
package = JSON.parse(File.read(File.join(__dir__, "package.json"))) | ||
package = JSON.parse(File.read(File.join(__dir__, 'package.json'))) | ||
|
||
Pod::Spec.new do |s| | ||
s.name = "stripe-react-native" | ||
s.version = package["version"] | ||
s.summary = package["description"] | ||
s.homepage = package["homepage"] | ||
s.license = package["license"] | ||
s.authors = package["author"] | ||
s.name = 'stripe-react-native' | ||
s.version = package['version'] | ||
s.summary = package['description'] | ||
s.homepage = package['homepage'] | ||
s.license = package['license'] | ||
s.authors = package['author'] | ||
|
||
s.platforms = { :ios => "11.0" } | ||
s.source = { :git => "https://github.com/stripe/stripe-react-native.git", :tag => "#{s.version}" } | ||
s.platforms = { ios: '11.0' } | ||
s.source = { git: 'https://github.com/stripe/stripe-react-native.git', tag: s.version.to_s } | ||
|
||
s.source_files = 'ios/**/*.{h,m,mm,swift}' | ||
|
||
s.source_files = "ios/**/*.{h,m,mm,swift}" | ||
|
||
|
||
s.dependency "React-Core" | ||
s.dependency 'Stripe', '~> 21.9.0' | ||
s.dependency 'React-Core' | ||
s.dependency 'Stripe', '~> 21.11.1' | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding a note for myself that we may want to add listeners for each of these events, not sure yet though