-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add jest mock file #565
add jest mock file #565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Such default mocks are super helpful. Left a few nits
is there a reason this was done in |
@jkepps use If it was done in TS they would have had to publish it uncompiled as well for non-TS consumers. Since this is an import that exists only to cause side-effects (not to expose api elements). That's not really a heavy burden for us consumers. |
got it, thanks @fbartho! |
closes #564