Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance payment sheet DX #506

Merged
merged 4 commits into from
Aug 12, 2021
Merged

Enhance payment sheet DX #506

merged 4 commits into from
Aug 12, 2021

Conversation

arekkubaczkowski
Copy link
Collaborator

closes #505

thorsten-stripe
thorsten-stripe approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@thorsten-stripe thorsten-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, otherwise LGTM, thanks.

ios/Errors.swift Show resolved Hide resolved
@arekkubaczkowski arekkubaczkowski merged commit 5e8045a into master Aug 12, 2021
@arekkubaczkowski arekkubaczkowski deleted the enhance-payment-sheet-dx branch August 12, 2021 06:45
@thorsten-stripe thorsten-stripe mentioned this pull request Sep 2, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@souhe souhe souhe approved these changes

@thorsten-stripe thorsten-stripe thorsten-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance the payment sheet DX
3 participants
@arekkubaczkowski @souhe @thorsten-stripe