Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Google pay android implementation #441

Merged
merged 42 commits into from
Jul 30, 2021
Merged

Conversation

arekkubaczkowski
Copy link
Collaborator

@arekkubaczkowski arekkubaczkowski commented Jul 20, 2021

resolves #9

  • create android bindings
  • create js methods and types
  • adapting the code to stripe-android breaking changes
  • write documentation

@ustkirill
Copy link

Hi guys!

Your package very useful, but I need google pay also, I tried use other packages, but it's not work. Do you have any time estimate for this PR?

Can I help with anything? :)

@jaaywags
Copy link

Can I help with anything? :)

Yes, I am happy to help too anywhere I can. Thanks!

Copy link
Contributor

@thorsten-stripe thorsten-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits regarding the button

android/build.gradle Outdated Show resolved Hide resolved
docs/GooglePay.md Show resolved Hide resolved
example/src/screens/GooglePayScreen.tsx Outdated Show resolved Hide resolved
example/src/screens/GooglePayScreen.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@thorsten-stripe thorsten-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@arekkubaczkowski arekkubaczkowski merged commit 961d6d1 into master Jul 30, 2021
@arekkubaczkowski arekkubaczkowski deleted the feat/google-pay-new branch July 30, 2021 09:44
@fredriksormo
Copy link

When will google pay be available in the expo version of this package?

@thorsten-stripe
Copy link
Contributor

When will google pay be available in the expo version of this package?

It will be available from Expo SDK 43 onward which is slotted for release in October.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Google Pay for Android
5 participants