Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: paymentsheet setupintents #298

Merged
merged 6 commits into from
Jun 3, 2021

Conversation

thorsten-stripe
Copy link
Contributor

Closes #293

@thorsten-stripe thorsten-stripe changed the title [WIP] feat: paymentsheet setupintents feat: paymentsheet setupintents Jun 2, 2021
Comment on lines +129 to +141
if (!paymentIntentClientSecret.isNullOrEmpty()) {
flowController?.configureWithPaymentIntent(
paymentIntentClientSecret = paymentIntentClientSecret!!,
configuration = paymentSheetConfiguration,
callback = onFlowControllerConfigure
)
} else if (!setupIntentClientSecret.isNullOrEmpty()) {
flowController?.configureWithSetupIntent(
setupIntentClientSecret = setupIntentClientSecret!!,
configuration = paymentSheetConfiguration,
callback = onFlowControllerConfigure
)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same pattern here

Copy link
Collaborator

@yuki-stripe yuki-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StripeSdk.swift changes lg2m

Copy link

@brnunes-stripe brnunes-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android API usage LGTM

@thorsten-stripe thorsten-stripe merged commit 2525dcc into master Jun 3, 2021
@thorsten-stripe thorsten-stripe deleted the feat/paymentsheet-setupintents branch June 3, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Payment sheet] add setup mode
5 participants