Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RN 0.73 Build error #1578 #1579

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

jgillick
Copy link
Contributor

Summary

After upgrading to React Native 0.73, the following Android build error is thrown:

Task :stripe_stripe-react-native:compileDebugKotlin FAILED
e: ~/mobile/node_modules/@stripe/stripe-react-native/android/src/main/java/com/reactnativestripesdk/CardFormView.kt:31:70 Unresolved reference: style

Motivation

Fixes #1578

Testing

I don't believe automated testing is necessary for this. Please advise.

  • I tested this manually
  • I added automated tests

Documentation

No documentation needed

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@CLAassistant
Copy link

CLAassistant commented Dec 13, 2023

CLA assistant check
All committers have signed the CLA.

@charliecruzan-stripe
Copy link
Collaborator

Thanks for adding this fix! I'm going to let the E2E tests run and will merge once those finish

@jgillick
Copy link
Contributor Author

The e2e failures weren't the result of this PR, were they? The android test almost looks like an environment issue. Let me know if I need to fix something.

@charliecruzan-stripe
Copy link
Collaborator

No they're unrelated, but i havent seen the android failure before 🤔 im not sure why were seeing that on this PR

@charliecruzan-stripe charliecruzan-stripe merged commit f1fe125 into stripe:master Dec 19, 2023
3 of 5 checks passed
@ahmadkhalaf1
Copy link

ahmadkhalaf1 commented Dec 31, 2023

@charliecruzan-stripe
have you released this already?

@charliecruzan-stripe
Copy link
Collaborator

Will release this tomorrow!

@ahmadkhalaf1
Copy link

Will release this tomorrow!

Thanks ^^ did you manage to release it already?

@charliecruzan-stripe
Copy link
Collaborator

released in 0.35.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error with RN 0.73
4 participants