Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support all PlatformPayButton props on Android, reduce library size #1534

Merged
merged 6 commits into from
Oct 17, 2023

Conversation

charliecruzan-stripe
Copy link
Collaborator

@charliecruzan-stripe charliecruzan-stripe commented Oct 16, 2023

Summary

Updates to use the new google pay button API, meaning we don't need to upgrade our asset files anymore 🎉 also this improves library size because we remove >200 XML assets

library size decrease

before:

package size:  829.8 kB
unpacked size: 4.0 MB

after:

package size:  256.5 kB
unpacked size: 1.7 MB

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@charliecruzan-stripe charliecruzan-stripe merged commit 5ae3fea into master Oct 17, 2023
1 check passed
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan/googlepaybuttonapi branch October 17, 2023 16:40
@gregavola
Copy link

@charliecruzan-stripe Any idea when this will be released? I'm currently blocked by Google Pay API acceptance, as they need the new button UI.

@bilal-korir
Copy link

@charliecruzan-stripe Any idea when this will be released? I'm currently blocked by Google Pay API acceptance, as they need the new button UI.

The same here. Our app's screen background is dark and it seems the appearance={PlatformPay.ButtonStyle.White} on android is not working. Google Pay API team rejected our request, because the button doesn't look nice due to colors contrast issue.

If you can publish this update to NPM/Yarn will be much appreciated. Thank you guys for your work.

@charliecruzan-stripe
Copy link
Collaborator Author

deployed in v0.34.0!

@bilal-korir
Copy link

deployed in v0.34.0!

You're the best, thank you @charliecruzan-stripe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants