Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: confirmSetupIntent with paymentMethodId shouldn't throw an error #1151

Merged
merged 1 commit into from
Sep 26, 2022
Merged

fix: confirmSetupIntent with paymentMethodId shouldn't throw an error #1151

merged 1 commit into from
Sep 26, 2022

Conversation

charliecruzan-stripe
Copy link
Collaborator

Summary

Fixes an issue on iOS where confirmSetupIntent would throw an error if the Card payment method was provided with the paymentMethodId parameter. We weren't checking for this before.

Motivation

closes #1124

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@charliecruzan-stripe charliecruzan-stripe merged commit 00f4cb9 into master Sep 26, 2022
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan/fix-1124 branch September 26, 2022 19:11
@asaarnak asaarnak mentioned this pull request Nov 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acomley-stripe acomley-stripe Awaiting requested review from acomley-stripe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stripe.instance.confirmSetupIntent throws PaymentMethodError.cardPaymentMissingParams on iOS only
1 participant
@charliecruzan-stripe