fix: do not publish unnecessary files #1043
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
we were including files that didn't need to be included bc package.json's
files
totally overrides.npmignore
. So even though we were ignoring subdirectories, it didn't matter.Removed
files
usage altogether, all appropriate file handling is in.npmignore
nowMotivation
Reduces the size of our distributed package
Testing
used
npm pack
and diff'd the before and after to ensure that only the expected files were deletedDocumentation
Select one: