Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the examples in the built sources #691

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

mapreri
Copy link
Contributor

@mapreri mapreri commented Nov 12, 2020

Thank you ♥

Signed-off-by: Mattia Rizzolo <mattia@mapreri.org>
@CLAassistant
Copy link

CLAassistant commented Nov 12, 2020

CLA assistant check
All committers have signed the CLA.

@remi-stripe
Copy link
Contributor

@mapreri Thanks for the PR! We'll have a look and let you know if we need anything else!

@richardm-stripe
Copy link
Contributor

Hi @mapreri, this looks good to me. Out of curiosity, what rationale/use case do you have for this, or what led you to open this PR?

@mapreri
Copy link
Contributor Author

mapreri commented Nov 17, 2020

Hi @mapreri, this looks good to me. Out of curiosity, what rationale/use case do you have for this, or what led you to open this PR?

I was building a Debian package for internal use at a customer and being the Debian Developer I am I try hard to follow our customs, which includes keeping as much documentation as offline as possible, including the examples. Indeed I tend to look up code locally than go and google about whatever I need. Since I found the examples small and useful I wished to have them near me.

@richardm-stripe richardm-stripe merged commit dc8fd30 into stripe:master Nov 20, 2020
@richardm-stripe
Copy link
Contributor

That makes sense. Thanks for the contribution! It'll go out in the next release.

@mapreri mapreri deleted the include-examples branch November 21, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants