Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quality issues reported by DeepSource #572

Merged
merged 2 commits into from
May 20, 2019
Merged

Fix quality issues reported by DeepSource #572

merged 2 commits into from
May 20, 2019

Conversation

sauravsrijan
Copy link
Contributor

Fixes:

  • PYL-C1801: Don't use len() to check for empty sequence
  • PYL-W0612: Rename unused variable to _
  • PYL-C0123: Use isinstance() for checking type

Fixes:
- PYL-C1801: Don't use len() to check for empty sequence
- PYL-W0612: Rename unused variable to `_`
- PYL-C0123: Use isinstance() for checking type
@ob-stripe
Copy link
Contributor

Hi @sauravsrijan, thanks for the contribution! These changes look good to me, but it looks like one of the files is not passing the formatting check. Can you run make fmt to have Black format the code and amend the PR?

@sauravsrijan
Copy link
Contributor Author

Hi @sauravsrijan, thanks for the contribution! These changes look good to me, but it looks like one of the files is not passing the formatting check. Can you run make fmt to have Black format the code and amend the PR?

Hey @ob-stripe, I updated the PR. Please have a look.

@ob-stripe
Copy link
Contributor

Awesome, thanks @sauravsrijan! Much appreciated.

@ob-stripe ob-stripe self-assigned this May 20, 2019
@sauravsrijan
Copy link
Contributor Author

No Problem! Looking forward to getting this PR merged!

@ob-stripe ob-stripe merged commit 2b0b375 into stripe:master May 20, 2019
@ob-stripe
Copy link
Contributor

Released as 2.28.1.

@sauravsrijan
Copy link
Contributor Author

Awesome! Thanks!

@sauravsrijan sauravsrijan deleted the fix-deepsource-issues branch May 21, 2019 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants