Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported bitcoin endpoint actions #463

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

tomer-stripe
Copy link
Contributor

This removes the ability to POST on the bitcoin endpoint. Tests passing for py27 and py37, I'm trying to figure out how to install other versions of Python:

lint inst-nodeps: /Users/tomer/stripe/stripe-python/.tox/dist/stripe-2.4.0.zip
lint installed: asn1crypto==0.24.0,certifi==2018.8.13,cffi==1.11.5,chardet==3.0.4,configparser==3.5.0,cryptography==2.3.1,enum34==1.1.6,flake8==3.5.0,idna==2.7,ipaddress==1.0.22,mccabe==0.6.1,pycodestyle==2.3.1,pycparser==2.18,pyflakes==1.6.0,pyOpenSSL==18.0.0,requests==2.19.1,six==1.11.0,stripe==2.4.0,urllib3==1.23
lint runtests: PYTHONHASHSEED='1865465412'
lint runtests: commands[0] | python -m flake8 --show-source stripe tests setup.py
________________________________________________________________ summary _________________________________________________________________
  py27: commands succeeded
SKIPPED:  py34: InterpreterNotFound: python3.4
SKIPPED:  py35: InterpreterNotFound: python3.5
SKIPPED:  py36: InterpreterNotFound: python3.6
  py37: commands succeeded
SKIPPED:  pypy: InterpreterNotFound: pypy
SKIPPED:  pypy3: InterpreterNotFound: pypy3
  lint: commands succeeded
  congratulations :)

@brandur-stripe
Copy link
Contributor

LGTM.

Just FYI though — because we're removing APIs here, we technically release this kind of as a breaking change. We don't have any hard and fast rules around when to do that, but we'll often opportunistically try to bring it in with other breaking changes to minimize the number of new major revisions we do.

I'm not sure whether there's anything like that outstanding in Python right now, but we might want to wait until @ob-stripe is back before merging and get his opinion on it (he's been doing most of the Python work lately).

This removes the ability to POST on the bitcoin endpoint. Tests passing for py27 and py37, I'm trying to figure out how to install other versions of Python:

I can give recommendations for a lot of languages, but I'm not familiar enough with the Python toolchain to give great advice here. I usually rely on CI to help me check the older stuff.

@remi-stripe
Copy link
Contributor

@brandur-stripe We just released the 2.X version for Python so I don't think there's any short term plan to do another major release soon.

I wonder if we would be okay removing those in a minor revision just because the API does not support those anymore. Do you know if we have actively removed support for update and delete for that endpoint? I know we don't support create for sure.

@brandur-stripe
Copy link
Contributor

@brandur-stripe We just released the 2.X version for Python so I don't think there's any short term plan to do another major release soon.

I wonder if we would be okay removing those in a minor revision just because the API does not support those anymore. Do you know if we have actively removed support for update and delete for that endpoint? I know we don't support create for sure.

Yeah, actually now that I look at the backend, it looks like all the non-GET actions are totally gone (update and delete). Given that means there's no chance using any of these can succeed these days, I'd be fine with doing something a little weird and removing these with just a minor version bump.

@brandur-stripe
Copy link
Contributor

LGTM.

@brandur-stripe brandur-stripe merged commit d715011 into master Aug 16, 2018
@brandur-stripe brandur-stripe deleted the tomer-remove-disabled-bitcoin-endpoints branch August 16, 2018 14:19
@brandur-stripe
Copy link
Contributor

Released as 2.5.0 with a special note in the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants