Fix items serialization when items is a dict #373
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @dpetrovics-stripe (DP run, feel free to re-assign)
cc @stripe/api-libraries @remi-stripe
Fixes an issue where if you set
items
to an integer-indexed dict on a subscription that was retrieved from the API, the library would try to unset the properties of the list object that was returned in theitems
attribute.This is basically exactly the same problem as the 2nd issue mentioned here: stripe/stripe-ruby#596, and the fix is similar (simply ignore the previous value of
items
).