Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move StripeClient usage collection onto StripeService #1223

Merged

Conversation

anniel-stripe
Copy link
Contributor

@anniel-stripe anniel-stripe commented Feb 5, 2024

A more disciplined way of ensuring that our "stripe_client" usage is only collected on client / service requests. This way, even if the APIRequestor ends up getting reused between client and resource requests, it won't sent the "stripe_client" usage on the resource request (see new test in tests/test_stripe_client.py).

@richardm-stripe richardm-stripe merged commit bd1c587 into master Feb 5, 2024
15 checks passed
@xavdid-stripe xavdid-stripe deleted the anniel-stripe-client-usage-on-stripe-service branch May 10, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants