Move resource type exports to stripe.___ #1142

pakrym-stripe · 2023-11-17T22:41:58Z

Deprecated modules are highlighted in pycharm and cause type errors in MyPy and Pyright, the warning is logged when importing deprecated module.

> python -c "import stripe.api_resources.card"
<string>:1: DeprecationWarning:
    The stripe.api_resources package is deprecated, please change your
    imports to import from stripe directly.
    From:
      from stripe.api_resources import ...
    To:
      from stripe import ...

Changelog

stripe.error, stripe.stripe_object, stripe.api_requestor, stripe.stripe_response, stripe.request_options, stripe.api_resources.*, stripe.api_resources.abstract.* modules are deprecated. All types are available directly from stripe module now.
Before:
```
from stripe.error import APIError
# or
stripe.error.APIError
```
After:
```
from stripe import APIError
# or
stripe.APIError
```

stripe/_account.py

richardm-stripe

Did the best I could spot-checking this and left some small questions. The approach in general looks good, and the import tests and the fact that the existing test suite passes gives me a lot of confidence.

stripe/api_resources/abstract/__init__.py

flake8_stripe/flake8_stripe.py

stripe/__init__.py

stripe/_api_resource.py

stripe/_encode.py

stripe/api_resources/recipient_transfer.py

stripe/stripe_object.py

anniel-stripe

Aside from the nits and bringing back recipient_transfer.py, this looks great to me! Love the deprecation warnings / tests / linter rules. And thanks for breaking it up into easy-to-review commits ❤️

andersk · 2023-12-07T22:45:14Z

stripe/__init__.py

+        def __getattr__(name):
+            if name == "abstract":
+                import stripe.api_resources.abstract as _abstract
+
+                return _abstract
+            if name == "api_resources":
+                import stripe.api_resources as _api_resources
+
+                return _api_resources


This needs to raise AttributeError rather than falling off the end and returning None.

[7.8.0 regression] stripe.checkout is None after import stripe #1158

Fix __getattr__ to raise AttributeError rather than returning None #1159

silviogutierrez · 2024-09-04T18:43:16Z

Docs should probably be updated: https://docs.stripe.com/error-handling?lang=python

Currently uses .error and mypy / type checkers complain.

ramya-stripe · 2024-09-09T20:47:28Z

Thanks for reporting that @silviogutierrez
We will look into updating the docs

pakrym-stripe force-pushed the pakrym/Move_resource_type_exports_to_stripe.___ branch 11 times, most recently from 222c0a2 to 6d0c5a0 Compare November 21, 2023 18:22

pakrym-stripe requested review from richardm-stripe and anniel-stripe November 21, 2023 19:35