Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress type errors from latest pyright #1126

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

richardm-stripe
Copy link
Contributor

See commit-by-commit.

For Fix redundant keyword params -- I checked that this was safe by looking into the implementation of _static_request or _request in each case and observing that util.read_special_variable was called (eventually) to grab the value from `params.

@pakrym-stripe
Copy link
Contributor

Do we have some tests that exercise these parameters?

Copy link
Contributor

@pakrym-stripe pakrym-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are red

@richardm-stripe
Copy link
Contributor Author

Turns out this is actually not safe. We don't use the little '*' trick to prevent keyword args from being passed positionally, so we have to suppress the type errors until we can do a major.

@richardm-stripe richardm-stripe changed the title Fix type errors from latest pyright Suppress type errors from latest pyright Nov 10, 2023
@richardm-stripe richardm-stripe merged commit 111323f into master Nov 10, 2023
15 checks passed
@richardm-stripe richardm-stripe deleted the richardm-unpin-pyright branch January 26, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants