Move Payment Intent to stripe-mock #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
force-pushed
the
remi-move-payment-intent-stripe-mock
branch
from
3f389e5 to
e4e64bc
Compare
|
Tests are sporadically failing, I tried to rebuild 3 times with no success |
ob-stripe
suggested changes
Jul 9, 2018
| "allowed_source_types" => ["card"], | ||
| "amount" => 100, | ||
| "currency" => "usd", | ||
| ]; | ||
|
|
||
| $this->stubRequest( |
There was a problem hiding this comment.
This should have been turned into expectsRequest.
remi-stripe
force-pushed
the
remi-move-payment-intent-stripe-mock
branch
from
e4e64bc to
0f09abb
Compare
|
@ob-stripe fixed, PTAL |
ob-stripe
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ob-stripe
cc @stripe/api-libraries